Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sentence Builder issue with "with_text()" #23

Open
charlesmarchand opened this issue Dec 24, 2020 · 2 comments
Open

Sentence Builder issue with "with_text()" #23

charlesmarchand opened this issue Dec 24, 2020 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@charlesmarchand
Copy link
Contributor

Arriving at this story :
image

I have this error :
erreur_tock_text

meaning that the if condition here :
image

is not respected, as it is going in the "else" (and thus having an error by checking the len() ), althought the text is an instance of I18nText

@francoisno francoisno added the bug Something isn't working label Jan 31, 2021
elebescond added a commit that referenced this issue Mar 6, 2021
Signed-off-by: Erwan LE BESCOND <[email protected]>
@elebescond
Copy link
Member

@charlesmarchand I think the with_text method is a mistake. I deleted it

For your need it would be necessary to do this

    bus.send("sentence1")
    bus.send("sentence2")
    bus.send(Sentence.Builder("sentence3")
             .add_suggestion("suggestion")
             .build())

@elebescond elebescond self-assigned this Mar 6, 2021
@charlesmarchand
Copy link
Contributor Author

Hi @elebescond ,
Yes no problem, I thought we were restricted to only one bus.send() per story ending, but I was wrong :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants