Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments/Notes #3

Open
thedamon opened this issue Feb 5, 2013 · 2 comments
Open

Comments/Notes #3

thedamon opened this issue Feb 5, 2013 · 2 comments
Labels

Comments

@thedamon
Copy link
Owner

thedamon commented Feb 5, 2013

Comments are definitely important.
I see two main ways of doing this:
1 - Have an all-encompassing comment type, that can reference any other type of entry either by IDRef, or association by similar enough datetime
2 - Include a comment/description field as a standard for all the types of entries or only certain ones.

I kind of think #1 makes sense from a data modelling point of view, but it may be more difficult to maintain, and I'm not sure if we want to worry about IDs (other than patient/timestamp).. part of the flexibility of JSON etc is not having to worry about incrementing/creating an ID.

@bernfarr
Copy link

Instead of directly referencing other data entries, could the reference be time-based? That way a comment that says "Took Tylenol" could be laid over the CGM readings for a 4 hour period to indicate that all of those may be affected?

If the comment has to directly reference these as a pointer of some sort, then adding or removing comments places a certain burden on the database. In the example above it would reference about 50 other entities.

@thedamon
Copy link
Owner Author

I agree. I think that makes most sense from a data modelling point of
view.. it's not our job to make connections.. it's the system's.
But does that same logic follow for things that are specifically related
like description of an exercise?

A way of dealing with that could be that notes have no explicit foreign key
relationship, but do have an optional categorization to apply to another
type of event.

On Tue, Feb 12, 2013 at 2:11 AM, Bernard Farrell
[email protected]:

Instead of directly referencing other data entries, could the reference be
time-based? That way a comment that says "Took Tylenol" could be laid over
the CGM readings for a 4 hour period to indicate that all of those may be
affected?

If the comment has to directly reference these as a pointer of some sort,
then adding or removing comments places a certain burden on the database.
In the example above it would reference about 50 other entities.


Reply to this email directly or view it on GitHubhttps://github.com//issues/3#issuecomment-13420779.

Damon Muma
@thedamon
226-268-0544
http://www.whatisdamon.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants