Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all GH60 layout options are supported. Toggling ISO/ANSI Enter allows all keys to be (re-)programmed as a workaround. #301

Open
3 of 6 tasks
Gregregorovich opened this issue Oct 19, 2024 · 0 comments

Comments

@Gregregorovich
Copy link

Gregregorovich commented Oct 19, 2024

Describe the bug
Not all GH60 layout options are supported. Toggling ISO/ANSI Enter allows all keys to be (re-)programmed as a workaround.

I have written a custom "design" draft definition, but I can't seem to be able to use it for some reason. See below.

To Reproduce
Steps to reproduce the behavior:

  1. Plug in a GH60 RevC (presumably with the Satan as well)
  2. Try to configure all three keys that appear/hide when using different types of Enter keys
  3. See that in ANSI mode it's split vertically and allows configuration of 1,13 and 2,13
  4. See that in ISO mode it's split horizontally and allows configuration of 2,12 and 2,13

Expected behavior
An additional Enter layout option that allows for all three keys (1,13 2,12 and 2,13) to be remappable without having to go to Layouts and toggle the Enter options.

Screenshots
N/A

VIA Version

Keyboard firmware VIA protocol
12

Desktop (please complete the following information):

  • OS: Windows 11
  • Browser: MS Edge

Custom json definition?

  • I am loading a custom json definition using the designer tab
  • I have written a custom json definition using the designer tab, but have not been able to apply it. It needed something in the lighting field as otherwise it wouldn't accept it, so I just pasted from known-working Keychron JSON as I don't use the 4 LED clusters supported by the RevC. Download here: GH60_revc_VIA_custom.json
or copy from this spoiler
{
"name": "GH60 Rev C All Keys",
"vendorId": "0x4335",
"productId": "0x0001",
"lighting": {
"extends": "qmk_rgblight",
"keycodes": "qmk",
"underglowEffects": [
    ["None", 0],
    ["SOLID_COLOR", 1],
    ["BREATHING", 1],
    ["BAND_SPIRAL_VAL", 1],
    ["CYCLE_ALL", 0],
    ["CYCLE_LEFT_RIGHT", 0],
    ["CYCLE_UP_DOWN", 0],
    ["RAINBOW_MOVING_CHEVRON", 0],
    ["CYCLE_OUT_IN", 0],
    ["CYCLE_OUT_IN_DUAL", 0],
    ["CYCLE_PINWHEEL", 0],
    ["CYCLE_SPIRAL", 0],
    ["DUAL_BEACON", 1],
    ["RAINBOW_BEACON", 0],
    ["JELLYBEAN_RAINDROPS", 10],
    ["PIXEL_RAIN", 0],
    ["TYPING_HEATMAP", 0],
    ["DIGITAL_RAIN", 0],
    ["REACTIVE_SIMPLE", 1],
    ["REACTIVE_MULTIWIDE", 1],
    ["REACTIVE_MULTINEXUS", 1],
    ["SPLASH", 0],
    ["SOLID_SPLASH", 1]
  ]
},
"matrix": {
  "rows": 5,
  "cols": 14
},
"layouts": {
  "labels": [
    "Split Backspace",
    [ "Enter Type",
      "ANSI Enter",
      "ISO Enter",
  	"All Enter"
    ],
    "Split Left Shift",
    "Split Right Shift",
    [
      "Bottom Row",
      "ANSI",
      "7U",
      "WKL",
      "HHKB"
    ]
  ],
  "keymap": [
    [
      {
        "x": 2.5
      },
      "0,0",
      "0,1",
      "0,2",
      "0,3",
      "0,4",
      "0,5",
      "0,6",
      "0,7",
      "0,8",
      "0,9",
      "0,10",
      "0,11",
      "0,12",
      {
        "c": "#aaaaaa",
        "w": 2
      },
      "0,13\n\n\n0,0",
      {
        "x": 0.25,
        "c": "#cccccc"
      },
      "0,13\n\n\n0,1",
      "4,9\n\n\n0,1"
    ],
    [
      {
        "x": 2.5,
        "c": "#aaaaaa",
        "w": 1.5
      },
      "1,0",
      {
        "c": "#cccccc"
      },
      "1,1",
      "1,2",
      "1,3",
      "1,4",
      "1,5",
      "1,6",
      "1,7",
      "1,8",
      "1,9",
      "1,10",
      "1,11",
      "1,12",
      {
        "w": 1.5
      },
      "1,13\n\n\n1,0",
      {
        "x": 1.25,
        "c": "#aaaaaa",
        "w": 1.25,
        "h": 2,
        "w2": 1.5,
        "h2": 1,
        "x2": -0.25
      },
      "2,13\n\n\n1,1",
  	{
        "w": 1.5
      },
      "1,13\n\n\n1,2"
    ],
    [
      {
        "x": 2.5,
        "w": 1.75
      },
      "2,0",
      {
        "c": "#cccccc"
      },
      "2,1",
      "2,2",
      "2,3",
      "2,4",
      "2,5",
      "2,6",
      "2,7",
      "2,8",
      "2,9",
      "2,10",
      "2,11",
      {
        "c": "#aaaaaa",
        "w": 2.25
      },
      "2,13\n\n\n1,0",
      {
        "x": 0.25,
        "c": "#cccccc"
      },
      "2,12\n\n\n1,1",
  	{
        "c": "#aaaaaa",
        "w": 1.25,
  	  "x2": 0.5
      },
      "2,12\n\n\n1,2",
  	{
        "c": "#cccccc",
        "w": 1,
  	  "x2": 0.5
      },
      "2,13\n\n\n1,2"
    ],
    [
      {
        "c": "#aaaaaa",
        "w": 1.25
      },
      "3,0\n\n\n2,1",
      {
        "c": "#cccccc"
      },
      "3,1\n\n\n2,1",
      {
        "x": 0.25,
        "c": "#aaaaaa",
        "w": 2.25
      },
      "3,0\n\n\n2,0",
      {
        "c": "#cccccc"
      },
      "3,2",
      "3,3",
      "3,4",
      "3,5",
      "3,6",
      "3,7",
      "3,8",
      "3,9",
      "3,10",
      "3,11",
      {
        "c": "#aaaaaa",
        "w": 2.75
      },
      "3,13\n\n\n3,0",
      {
        "x": 0.25,
        "w": 1.75
      },
      "3,13\n\n\n3,1",
      "3,12\n\n\n3,1"
    ],
    [
      {
        "x": 2.5,
        "w": 1.25
      },
      "4,0\n\n\n4,0",
      {
        "w": 1.25
      },
      "4,1\n\n\n4,0",
      {
        "w": 1.25
      },
      "4,2\n\n\n4,0",
      {
        "c": "#cccccc",
        "w": 6.25
      },
      "4,5\n\n\n4,0",
      {
        "c": "#aaaaaa",
        "w": 1.25
      },
      "4,10\n\n\n4,0",
      {
        "w": 1.25
      },
      "4,11\n\n\n4,0",
      {
        "w": 1.25
      },
      "4,12\n\n\n4,0",
      {
        "w": 1.25
      },
      "4,13\n\n\n4,0"
    ],
    [
      {
        "y": 0.25,
        "x": 2.5,
        "w": 1.5
      },
      "4,0\n\n\n4,1",
      "4,1\n\n\n4,1",
      {
        "w": 1.5
      },
      "4,2\n\n\n4,1",
      {
        "c": "#cccccc",
        "w": 7
      },
      "4,5\n\n\n4,1",
      {
        "c": "#aaaaaa",
        "w": 1.5
      },
      "4,11\n\n\n4,1",
      "4,12\n\n\n4,1",
      {
        "w": 1.5
      },
      "4,13\n\n\n4,1"
    ],
    [
      {
        "x": 2.5,
        "w": 1.5
      },
      "4,0\n\n\n4,2",
      {
        "c": "#cccccc",
        "d": true
      },
      "\n\n\n4,2",
      {
        "c": "#aaaaaa",
        "w": 1.5
      },
      "4,2\n\n\n4,2",
      {
        "c": "#cccccc",
        "w": 7
      },
      "4,5\n\n\n4,2",
      {
        "c": "#aaaaaa",
        "w": 1.5
      },
      "4,11\n\n\n4,2",
      {
        "c": "#cccccc",
        "d": true
      },
      "\n\n\n4,2",
      {
        "c": "#aaaaaa",
        "w": 1.5
      },
      "4,13\n\n\n4,2"
    ],
    [
      {
        "x": 2.5,
        "c": "#cccccc",
        "w": 1.5,
        "d": true
      },
      "\n\n\n4,3",
      {
        "c": "#aaaaaa"
      },
      "4,1\n\n\n4,3",
      {
        "w": 1.5
      },
      "4,2\n\n\n4,3",
      {
        "c": "#cccccc",
        "w": 7
      },
      "4,5\n\n\n4,3",
      {
        "c": "#aaaaaa",
        "w": 1.5
      },
      "4,11\n\n\n4,3",
      "4,12\n\n\n4,3",
      {
        "c": "#cccccc",
        "w": 1.5,
        "d": true
      },
      "\n\n\n4,3"
    ]
  ]
}
}

Sanity checks

Additional context
The custom layout only works on https://usevia.app, and not on the downloadable v2.2.0 nor 3.0.0 Windows application; it errors with [...].json Object: should NOT have additional properties.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant