Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated to Discord.js v14 #24

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Updated to Discord.js v14 #24

wants to merge 11 commits into from

Conversation

eirikhanasand
Copy link

@eirikhanasand eirikhanasand commented Dec 15, 2024 •
edited
Loading

khinshankhan
khinshankhan reviewed Dec 15, 2024
View reviewed changes
package.json
"flexsearch": "^0.7.21",
"glob": "^7.2.0",
"node-fetch": "^2.6.6",
"pm2": "^5.1.2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was pm2 removed?

Copy link
Author

@eirikhanasand eirikhanasand Dec 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it was installed but there is no reference to it in the code, nor is it referenced by any other dependency neither top level nor sublevel nor any script nor the dockerfile. In other words, I found no indication that it was being used. Saw no reason to include it when it isnt used.

@eirikhanasand
Copy link
Author

Added a commit for discord.js-docs v 0.4.3 which was published earlier today, where an issue in that library that caused a top level error was resolved (see TeeSeal/discord.js-docs#30). I also changed the default query "Client" to "a", and moved this to constants.ts and named it DEFAULT_SEARCH_QUERY to make it more explicit what the role of this variable is. Previous to this PR there was no default query, which resulted in no results appearing before you started typing. I feel like an alphabetically ordered list is better than just "Client" appearing, which was why I changed it to just "a".

@eirikhanasand
Copy link
Author

Added DEFAULT_SEARCH_QUERY for mdn docs as well (this was already "a", but now refers to the same constant instead of just a inline char. Also moved the DJSAutocomplete from InteractionCreateHandler.ts -> commands/docs/djs.ts to ensure both files follow the same structure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khinshankhan khinshankhan khinshankhan left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@eirikhanasand @khinshankhan