Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bug: Application does not respond when querying MDN docs. #21

Open
eirikhanasand opened this issue Nov 27, 2024 · 0 comments · May be fixed by #24
Open

🐛 Bug: Application does not respond when querying MDN docs. #21

eirikhanasand opened this issue Nov 27, 2024 · 0 comments · May be fixed by #24

Comments

@eirikhanasand
Copy link

Summary

When querying the application for MDN docs, it hangs forever. Based on the source code its likely that it throws an error, which is then logged, but this is never returned to the user, creating an illusion of the bot hanging forever.

Example queries:

  1. Array.filter
  2. Array.filter()
  3. Sort
  4. Array.prototype.sort
  5. Array.prototype.sort()
  6. string
  7. number

Why this is a problem

The consequence of this issue is that the requested data nor any error message is ever returned to the user.

Expcted outcome

The expected outcome of querying the bot is that the result is returned to the user, or an error if there is no way to handle the query or the data that comes from it.

Proposed solution

The most logical solution (imo) would be divided in three parts:

  1. Return any error message to the user to give clear feedback regardless of the outcome
  2. Slice the message to avoid overlengthy embeds
  3. Add paging to the results to avoid cutting out important information
@eirikhanasand eirikhanasand linked a pull request Dec 15, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant