-
Notifications
You must be signed in to change notification settings - Fork 766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
links in trip dash board to drives don't work with NixOS module installation #4471
Comments
I guess, you were coming from the Drives dashboard, clickiing on the date??!?
What do you mean with "click it"?!? What did you click in the Drive Details dashboard? |
Yes, that is correct. |
How did you get to the second link then? |
I assume this causes the malformed URL, as I cannot reproduce on docker installation. |
Think there might be some confusion in my description. I looked at the source link for the date column. This is correct. After I execute the link (by clicking on it or copying and pasting it) I look at final the destination. That is not correct. Is this clear now? |
Hot entirely convinced. But have no evidence. What perhaps could be important is I have grafana 11.3.1. I notice nixos 24.11 now has 11.3.2 I don't see anything relevant in the changelog, but probably should upgrade. |
We missed to exclude one config setting when upgrading grafana in the nix config i guess. Only did it in the dockerfile, will open a pr shortly |
Line 259 in 61fc3b2
|
Nice catch, ty! |
Is there an existing issue for this?
What happened?
A link in the trip dashboard to a drive looks like:
https://tesla.linuxpenguins.xyz/d/zm7wN6Zgz/drive-details?from=1735973398000&to=1735974949000&var-car_id=1&var-drive_id=10702
To me this looks correct, but haven't checked it. But after I click it (or copy it into the URL bar) I get redirected to:
https://tesla.linuxpenguins.xyz/d/zm7wN6Zgz/drive-details?from=now-12h&to=now&var-car_id=1&var-drive_id=10702&orgId=1&var-temp_unit=C&var-length_unit=km&var-alternative_length_unit=m&var-preferred_range=rated&var-base_url=https:%2F%2Fteslamate.linuxpenguins.xyz&var-pressure_unit=psi&var-speed_unit=km%2Fh
Note to from= and time= are very different. What I see is a chart showing the last 12 hours, but this doesn't include the drive I just clicked on.
Not sure if it is significant or not that the drive is from yesterday. Can't check for a drive from today yet, the car hasn't gone anywhere. But I seem to remember similar odd behavior.
Expected Behavior
Clicking the drive should show me the timespan for the drive and nothing else.
Steps To Reproduce
No response
Relevant log output
Screenshots
No response
Additional data
This is the install using the nixos module.
Either the URL parameters do not seem to be working, or something is overriding them.
Type of installation
Manual
Version
mcu2-upgraded-cars 8d4da30 (just rebased aaginst latest master)
The text was updated successfully, but these errors were encountered: