Skip to content
This repository has been archived by the owner on Dec 17, 2024. It is now read-only.

Default value for cloud shell settings #14

Closed
in-1911 opened this issue Aug 12, 2024 · 3 comments
Closed

Default value for cloud shell settings #14

in-1911 opened this issue Aug 12, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request internal-synced

Comments

@in-1911
Copy link

in-1911 commented Aug 12, 2024

Description

Since the account infrastructure base DA has an issue with cloud shell settings when using a service ID (or trusted profile), the default for skip_cloud_shell_calls should be set to true.

New or affected modules


By submitting this issue, you agree to follow our Code of Conduct

@in-1911 in-1911 added the enhancement New feature or request label Aug 12, 2024
@ocofaigh
Copy link
Member

@in-1911 I guess you wan't skip_cloud_shell_calls to default to true in the stack? But should we expose it as a stack level input incase someone is not using service ID or TP?

@in-1911
Copy link
Author

in-1911 commented Aug 13, 2024

Technically we can expose it, but I think if we keep doing that, the stack inputs will become unmanageable.
The users still can change it at the DA level if there is a real need for that.
In this particular case, this option is not material for the solution functionality, and I do not remember that setting used in SCC profiles I used.

The drawback of setting the default in the stack is that the current projects functionality requires a manual user's input to override it while ignoring the matching values from the environment.

The problem with leaving it enabled is that the error is rather vague and it's not even documented in the Account Infra Base that you have to turn it off if using trusted profile or a service ID for deployment.

@vburckhardt
Copy link
Member

I'd change the settings of the account settings da rather than the stack to have a global common behavior here across all users of that da

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request internal-synced
Projects
None yet
Development

No branches or pull requests

6 participants