Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sampleStorageLocation property #206

Open
edmondchuc opened this issue Nov 28, 2022 · 3 comments
Open

Remove sampleStorageLocation property #206

edmondchuc opened this issue Nov 28, 2022 · 3 comments

Comments

@edmondchuc
Copy link
Contributor

There has been no evidence of usage for this property.

@miekeGR
Copy link

miekeGR commented Nov 28, 2022

Hi @edmondchuc I didn't realise this property existed in the ontology previously. While I do not personally need it right now, I can definitely see its benefits e.g. knowing which storage facility has a particular specimen. But I guess the alternative could be describing this with a more in depth qualifiedAttribution rather than via a geometry. Is that what you do?

@edmondchuc
Copy link
Contributor Author

Yes, it would be useful except the current sampleStorageLocation is modelled as a sub-property of geo:hasGeometry. So rather than saying which storage facility the specimen is stored at, it's only saying what the location is.

tern:sampleStorageLocation
    a rdf:Property ;
    rdfs:label "sample storage location" ;
    rdfs:subPropertyOf <http://www.opengis.net/ont/geosparql#hasGeometry> ;
    skos:definition "A property that links a specimen sample to the location of where it is stored." ;
.

If we do keep sampleStorageLocation around, it should not be a sub-property of geo:hasGeometry and the target nodes may need to be something else (like schema:Place).

I wouldn't suggest using prov:qualifiedAttribution as it's only for linking some entity (in this case the sample) to an agent with a role (owner, rights holder, etc).

@miekeGR
Copy link

miekeGR commented Nov 29, 2022

Cheers, thanks for that explanation @edmondchuc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants