Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pre-commit CI job #60

Closed
mmanzoorTT opened this issue Nov 8, 2024 · 2 comments · Fixed by #66
Closed

Add pre-commit CI job #60

mmanzoorTT opened this issue Nov 8, 2024 · 2 comments · Fixed by #66
Assignees
@kmitrovicTT

Comments

@mmanzoorTT
Copy link
Contributor

CI is not verifying the code formatting. Add GitHub workflow to add the pre-comm CI pipeline.
@mmanzoorTT
Copy link
Contributor Author

mmanzoorTT commented Nov 8, 2024 •
edited
Loading

tenstorrent/tt-torch#13 adds multiple pipelines for github workflow for tt-torch repo. It can be used as reference to add pre-commit pipeline. Please verify if any other pipeline is missing.

@mmanzoorTT
Copy link
Contributor Author

Here is another PR tenstorrent/tt-torch#28

it first runs pre-commit and license checks; if successful then it runs the remaining jobs.

@kmitrovicTT kmitrovicTT mentioned this issue Nov 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kmitrovicTT kmitrovicTT

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added gh CI workflows tenstorrent/tt-xla
2 participants
@kmitrovicTT @mmanzoorTT