Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable N300 #9

Open
AleksKnezevic opened this issue Sep 20, 2024 · 7 comments · May be fixed by #145
Open

Enable N300 #9

AleksKnezevic opened this issue Sep 20, 2024 · 7 comments · May be fixed by #145
Assignees

Comments

@AleksKnezevic
Copy link
Contributor

Currently tests fail on N300, please fix and enable CI

@AleksKnezevic
Copy link
Contributor Author

@LPanosTT, can you please take a look at this?

@nsmithtt
Copy link

@mrakitaTT, we're getting closer to running more multi-device tests and we'd like to leverage Jax to do so. Do you know if this is still an issue?

@mrakitaTT
Copy link
Contributor

@nsmithtt no one has worked on this yet and we still have a hardcoded int device_info_count_ = 1; hack in order to be able to use n300 devices to run tests. The last tech sync when Wooseok was presenting the multi device progress I was wondering how is he getting the hlo graphs and if he is using tt-xla for his work, but haven't yet gotten to asking him.

@ajakovljevicTT this might be a good PJRT task for you or Sanja, can you please investigate what fails when you disable the device count hack and how device is selected in PJRT etc?

@nsmithtt
Copy link

nsmithtt commented Dec 12, 2024

I think we got multi device stableHLO IR from a multi-device google collab and have been working directly from the stablehlo. Or @wooseokTT did you hack PJRT to make it work for a one off test?

Thanks for looking into it @ajakovljevicTT!

@wooseokTT
Copy link

@nsmithtt @mrakitaTT I have local fix that uses device ids instead of the hardcoded "1". Then, I used matmul python code to generate stableHLO mlir using tt-xla.

@ajakovljevicTT
Copy link
Contributor

@wooseokTT Would you mind sharing that fix in a branch? Thanks!

@wooseokTT
Copy link

wooseokTT commented Dec 12, 2024

@ajakovljevicTT It's not a big change. I just fixed code to the point where I can run multidevice, and didn't test any other things.

auto [system_desc, chip_ids] = tt::runtime::getCurrentSystemDesc();
#if TEST_MESH
int device_info_count_ = chip_ids.size();
#else
int device_info_count_ = 1;
#endif

auto [system_desc, chip_ids] = tt::runtime::getCurrentSystemDesc();
#if TEST_MESH
auto device = tt::runtime::openDevice(chip_ids);
#else
int dev_0 = chip_ids[0];
auto device = tt::runtime::openDevice({dev_0});
#endif

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants