Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tt-smi appears to phone home serial numbers without user's consent or knowledge #42

Open
afaerber opened this issue Sep 12, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@afaerber
Copy link
Contributor

The display of latest software versions appears to work via tt-tools-common getting a list of board IDs and querying cereal.tenstorrent.com for each board ID, i.e., serial number.

  • Sending serial numbers home to the vendor seems a privacy concern. It should be opt-in with the user's awareness of what is being transmitted.
    The README.md section "Latest SW Versions" doesn't say anything either.
  • The get_sw_ver_info function's argument show_sw_ver is supplied in tt_smi.py from get_latest_sw_vers = reactive(True), but there is no obvious way to toggle it.
  • Even if there were a keyboard binding or checkbox, due to a bug in tt-tools-common it would still check online, just not return the obtained versions (get_sw_ver_info() gets version info from Internet even if asked not to show any tt-tools-common#7).
  • There is only one set of version numbers displayed in the bottom left box, even if I have two cards installed (cf. get_sw_ver_info() returns only versions for the last board ID tt-tools-common#8).
    screenshot of Latest SW Versions in tt-smi
    If a display per device were intended, both the API and the UI would need changes, such as adding a fourth tab or extending the FW Version tab with an actual / latest notation for the bundle and possibly tt-flash.
  • Since the components all seem shared between cards and there being only one latest version for each component, it seems unnecessary to query for each card. A single query without ?SerialNumber= argument could return those version numbers just as well.
    Fake https://cereal.tenstorrent.com/?SerialNumber=42 works just fine, so there doesn't appear to be any actual check of the serial number currently (but requests likely get logged by the webserver).
    In theory, the most hardware-specific component should be the kernel driver, which should go into mainline Linux at some point anyway and would then no longer apply to this list (cf. Do you have plans to upstream it?  tt-kmd#19).
afaerber added a commit to afaerber/tt-tools-common that referenced this issue Sep 14, 2024
If get_sw_ver_info() argument show_sw_ver is False, there's no need to
obtain version numbers from the Internet to then discard then.

Reorder the argument check to return immediately.

Relates to issue tenstorrent/tt-smi#42.

Signed-off-by: Andreas Färber <[email protected]>
afaerber added a commit to afaerber/tt-tools-common that referenced this issue Sep 14, 2024
If get_sw_ver_info() argument show_sw_ver is False, there's no need to
obtain version numbers from the Internet to then discard them.

Reorder the argument check to return immediately.

Relates to issue tenstorrent/tt-smi#42.

Signed-off-by: Andreas Färber <[email protected]>
@milank94 milank94 added the bug Something isn't working label Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants