Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt new device runtime #19

Closed
staylorTT opened this issue Jun 19, 2024 · 5 comments · Fixed by #185
Closed

Adopt new device runtime #19

staylorTT opened this issue Jun 19, 2024 · 5 comments · Fixed by #185
Assignees

Comments

@staylorTT
Copy link
Contributor

No description provided.

@nsmithtt
Copy link
Contributor

nsmithtt commented Jun 28, 2024

Since we don't have an official repo for the new Buda, we pushed to the gitlab repo on branch aknezevic/refactor.

Notes:

  • Core file adopting the new runtime: pybuda/csrc/tt_torch_device/tt_device.cpp
  • Other relevant files:
    • pybuda/csrc/tt_torch_device/python_bindings.cpp
    • pybuda/pybuda/torch_compile.py
    • pybuda/csrc/tt_torch_device/torch_device_impl.cpp
  • Only builds on ubuntu 20.04
  • Right now the build is pretty fragile, you need to manually cd into third_party/tt-mlir and build the project manually before building pybuda. Be sure to build with -DTTMLIR_ENABLE_RUNTIME=ON
  • Please refer to internal build notes: https://tenstorrent.github.io/tt-mlir/internal-build.html
  • Tight sync / integration with issue Emit tt:Graph as TTIR Dialect #8

I think there are also large opportunities to continue refactoring. The refactoring is a large effort, but I'm not sure how to capture it as a set of issues.

@nsmithtt nsmithtt changed the title Move to 100% torch runtime implementation Adopt new device runtime Jun 28, 2024
@pilkicTT
Copy link
Contributor

This issue is tightly coupled with #18 and #8. After the changes for those two are merged, I will proceed with this item.

@pilkicTT
Copy link
Contributor

Update: in progress - have a working version, but still needs to be cleaned up. PR(s) should follow soon.

@pilkicTT
Copy link
Contributor

Once this PR is complete we can close this issue.

@pilkicTT
Copy link
Contributor

Closing the issue, PR has been completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants