-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup of sub device manager state inside device to simplify porting to meshdevice #16625
Labels
Comments
@cfjchu fyi |
2 tasks
tt-aho
added a commit
that referenced
this issue
Jan 13, 2025
… class to enable easy porting for MeshDevice
6 tasks
tt-aho
added a commit
that referenced
this issue
Jan 14, 2025
… class to enable easy porting for MeshDevice
tt-aho
added a commit
that referenced
this issue
Jan 14, 2025
… class to enable easy porting for MeshDevice
tt-aho
added a commit
that referenced
this issue
Jan 14, 2025
… class to enable easy porting for MeshDevice
tt-aho
added a commit
that referenced
this issue
Jan 14, 2025
… class to enable easy porting for MeshDevice
tt-aho
added a commit
that referenced
this issue
Jan 14, 2025
… class to enable easy porting for MeshDevice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, the single device object manages a number of different attributes regarding what the configured manager is, and if we want to uplift the SubDeviceManager concept to the mesh device level, this would require MeshDevice to copy/implement all of this logic as well, even though the logic would basically be duplicated.
The current thought/plan is to hoist all of this into an owning object that manages all of this, and then device/mesh device just needs instantiate this single owning object that they can query to get ex the active/default managers.
Ex. Change the existing SubDeviceManager to be SubDeviceConfiguration, and have the new owning object be the SubDeviceManager (final naming tbd)
The text was updated successfully, but these errors were encountered: