Unsqueeze pytorch operator test plan #986
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgolubovicTT
approved these changes
Jan 10, 2025
vobojevicTT
force-pushed
the
vobojevic/pytorch-unsqueeze-test
branch
from
34ac560 to
0fe6a0e
Compare
vobojevicTT
commented
Jan 10, 2025
| dims = list(range(-dim - 1, dim + 1)) | ||
|
|
||
| for i in dims: | ||
| yield {"dim": i} |
There was a problem hiding this comment.
@dgolubovicTT @vbrkicTT Here, we generate all possible dim values, which creates 2598 tests. The test run takes around 20 minutes. Should we skip some dims?
There was a problem hiding this comment.
It doesn't sound yet critical however we might introduce some limits for number of tests on PR/nightly
There was a problem hiding this comment.
I wouldn't skip some dim for all tests. Maybe sampling subset of tests will provide uniform testing for all shapes and dimensions? We could do that by choosing subset of dims randomly with seed based on input shape (therefore we would get the same subset for the same shape). What do you think?
vobojevicTT
force-pushed
the
vobojevic/pytorch-unsqueeze-test
branch
from
0fe6a0e to
0f80fed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test plan for pytorch unsqueeze operator.
Local run (no failing rules):
16 failed, 2582 passed in 938.44s (0:15:38)