Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update github.com/go-git/go-git/v5 from v5.12.0 to v5.13.1 #8474

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

SaschaSchwarze0
Copy link
Contributor

@SaschaSchwarze0 SaschaSchwarze0 commented Jan 8, 2025

Changes

Not sure why dependabot has not opened a pull request. govulncheck clearly reports this repository being affected by the vulnerability.

Fixes CVE-2025-21613
Fixes CVE-2025-21614

/kind security

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none Denotes a PR that doesnt merit a release note. labels Jan 8, 2025
@tekton-robot
Copy link
Collaborator

Hi @SaschaSchwarze0. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 8, 2025
@tekton-robot tekton-robot requested review from abayer and jerop January 8, 2025 16:17
@SaschaSchwarze0
Copy link
Contributor Author

/retest
/kind security

@tekton-robot tekton-robot added the kind/security Categorizes issue or PR as related to a security issue label Jan 9, 2025
@tekton-robot
Copy link
Collaborator

@SaschaSchwarze0: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest
/kind security

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vdemeester
Copy link
Member

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 13, 2025
@SaschaSchwarze0
Copy link
Contributor Author

SaschaSchwarze0 commented Jan 13, 2025

@vdemeester thanks for ok-to-test. Can you help me with two things:

  1. I initially marked it with kind/cleanup until I noticed there is a kind/security. Now the PR has two labels and the kind check fails complaining on this. But I do not know how to remove kind/cleanup. Can you let me know the command or simply remove the label? Ty.
  2. The e2e failure. Failing is "TestExamples/v1/taskruns/entrypoint-resolution" and I see failed to create task run pod "entrypoint-resolution": translating TaskSpec to Pod: GET https://production.cloudflare.docker.com/registry-v2/docker/registry/v2/blobs/sha256/b1/b1d9df8ab81559494794e522b380878cf9ba82d4c1fb67293bcf931c3aa69ae4/data?verify=REDACTED: unexpected status code 403 Forbidden: {"status":403,"message":"Error: invalid URL signature"}. Maybe invalid TaskSpec which is maybe related. I'll try a /retest, but if you have other insights, let me know.

@SaschaSchwarze0
Copy link
Contributor Author

/retest

@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 14, 2025
@vdemeester vdemeester removed the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jan 14, 2025
@vdemeester
Copy link
Member

@SaschaSchwarze0 arf, it needs a rebase now.

@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 14, 2025
@SaschaSchwarze0
Copy link
Contributor Author

@vdemeester done

Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah go-billy got released 👼🏼
cc @afrittoli @waveywaves

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 14, 2025
Copy link
Member

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2025
@tekton-robot tekton-robot merged commit 4617ed7 into tektoncd:main Jan 14, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/security Categorizes issue or PR as related to a security issue lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesnt merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants