Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Sharing of Slide Show #7

Open
tedbarnett opened this issue Aug 28, 2023 · 5 comments
Open

Enable Sharing of Slide Show #7

tedbarnett opened this issue Aug 28, 2023 · 5 comments

Comments

@tedbarnett
Copy link
Owner

The ultimate output of this product is two-fold:

  1. User is able to correct date/time and location of photos in his own photo collection in a more convenient way (i.e. changes made in the app are saved to the EXIF data for each photo in their original form)
  2. User is able to share a completed slide show that plays the photos that were voice-annotated (or date-stamped or location-added) to other friends or save back to one's own photo library.

We are already working on item 1 above (Issue #3 ), but for the second:

Add a "Share" button to the top left of the Slide Show screen. When clicked, generate a single shareable video file containing the slide show (photos played in chronological order, with audio), then open a standard share dialog allowing the user to share the video via Messenger, or Files, or whatever is allowed on that user's iPhone.

@tedbarnett
Copy link
Owner Author

As an example, here is the share dialog we generated in another video-based app:

image

@prempratapsingh
Copy link
Collaborator

Sharing a video recording of the slide show is great idea 👍

@tedbarnett
Copy link
Owner Author

Let's add this as a menu item

@prempratapsingh
Copy link
Collaborator

hey @tedbarnett , could you please answer these queries related to the share functionality?

  1. Can a user share slide show video after completion of the slide show i.e. all of the slide show photos are played back in slide show? Or user can share video anytime while the slide show presentation is in progress?
  2. Is it okey to export video in MP4 format only? Or you want the video in any other format?
  3. Should we include only those photos in exported video that have audio annotation?
  4. If we need to add photos with updated date and/or location by the user, do we need to show those updated information with the photo in the exported video?

@tedbarnett
Copy link
Owner Author

  1. Anytime. It should make a video of whatever you have already added data to. And save that video in a list with a name (video1), date, and time. Users can rename the file ("Mom photos"), but the date/time are based on when the video was made.
  2. MP4 only is okay
  3. Yes per Read EXIF data from photos #2 in the Issue ("plays the photos that were voice-annotated (or date-stamped or location-added")
  4. Good point. As a default, let's show the location and date (not the time) in a small transparent white font at the bottom-right of each photo in the video. Only show what is available (i.e. if a field is empty, don't show it). Should look like:

Cohasset, MA
July 6, 1965

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants