Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Photos appear improperly cropped #24

Open
tedbarnett opened this issue Oct 3, 2023 · 4 comments
Open

Photos appear improperly cropped #24

tedbarnett opened this issue Oct 3, 2023 · 4 comments
Labels
0) bug Must fix

Comments

@tedbarnett
Copy link
Owner

When I tap a photo from the main screen, I sometimes (often!) see the photo showing up cropped incorrectly. Whenever a photo is tapped, the details page should show the photo zoomed "to fit" so that all of the photo is visible.

@tedbarnett tedbarnett added the 0) bug Must fix label Oct 3, 2023
@tedbarnett
Copy link
Owner Author

Example:

image

image

@tedbarnett
Copy link
Owner Author

Ignore the red line above: accidentally added.

@prempratapsingh
Copy link
Collaborator

prempratapsingh commented Oct 20, 2023

Ah, I see. Some part of the photo is being cropped due to the fill image content mode. We have two content mode for image in iOS - fit mode and fill mode. If we set the fill mode, the image would fill the available space and would crop some part of the image as needed. Fit mode, makes sure that entire content of the image is displayed in the available space.

Now, I have set the image content mode to fit and now the images taken in portrait mode looks like this. Is this okey?



@prempratapsingh
Copy link
Collaborator

Images taken in landscape would would look like this,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0) bug Must fix
Projects
None yet
Development

No branches or pull requests

2 participants