Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable pinch-zoom on photos #12

Open
tedbarnett opened this issue Sep 13, 2023 · 2 comments
Open

Enable pinch-zoom on photos #12

tedbarnett opened this issue Sep 13, 2023 · 2 comments
Labels
2) Medium Priority

Comments

@tedbarnett
Copy link
Owner

When editing a photo, users might want to zoom in or pan around the image to see it better. So...

  • allow user to pinch-zoom or drag-and-pan on photos (but don't cover the text area below where the EXIF data is entered)
  • tapping outside the photo should return it to normal size
@prempratapsingh
Copy link
Collaborator

Its done. Now you can pinch to zoom in/out and pan the photo under photo details view.
Double tap on the photo to restore the photo to original state. It was technically complex to restore photo to original state when tapped outside the photo so, implemented double tap gesture.

@tedbarnett
Copy link
Owner Author

The double-tap is nice. One issue: the pinch-zoom should be centered on the area between my fingers. Seems like it is not. Compare to how pinch-zoom works on Apple apps.

prempratapsingh added a commit that referenced this issue Dec 8, 2023
@prempratapsingh
Implement changes as part of Github issues #12, #19, #20
d177682
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2) Medium Priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tedbarnett @prempratapsingh