Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce --update invocations in tests #390

Open
niklasmohrin opened this issue Nov 14, 2024 · 1 comment
Open

Reduce --update invocations in tests #390

niklasmohrin opened this issue Nov 14, 2024 · 1 comment
Assignees

Comments

@niklasmohrin
Copy link
Collaborator

We have a lot of tests that initially run tldr --update. This is unnecessary as we could just place the needed pages in the temporary cache directory ourselves. This would a) speed up the tests, because they don't need to download the whole archive from the internet, b) remove unneeded internet traffic and c) make the tests reproducible and runnable in offline environments (like nix builds).

All tests not directly testing the update procedure should be changed.

@niklasmohrin
Copy link
Collaborator Author

Once #337 is merged, we can use it to set up our own update server when the tests are running. We should keep at least one test that actually updates from the official source, but it should be ignored by default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant