Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor spec editorial issues #186

Open
simonbuchan opened this issue Feb 27, 2018 · 0 comments · May be fixed by #198
Open

Minor spec editorial issues #186

simonbuchan opened this issue Feb 27, 2018 · 0 comments · May be fixed by #198

Comments

@simonbuchan
Copy link

I'm walking through the spec implementing it as described as literally as possible in JS and ran into a few editorial issues, thought I might as well list them here as I go:

  • 2.2 step 5.a sets iteratorMethod to ? GetMethod(x,@@observable), this should be @@iterator
  • 2.2.2 Observable.from Iteration Functions first paragraph declares a [[IteratorFunction]], this should be [[IteratorMethod]]
  • 2.2.2 Step 3 sets iterator to ? GetIterator(items, iteratorMethod):
    • items should be iterable
    • GetIterator in the linked current spec is declared as GetIterator ( obj [, hint [, method ] ] ), requires adding hint as sync
  • 3.1 Observable.prototype.subscribe steps 8.b.ii and 10:
    • both run (if the subscription does not close) and HostReportErrors on the same result value.
    • Step 10 will use an unassigned result if startMethodResult is not a normal completion.

Here's the gist I ended up with (from the new jsbin alpha): https://gist.github.com/anonymous/cf78e27c047e7747048941cb51921d63#file-wispy-dawn-fde-js

@dead-claudia dead-claudia linked a pull request Aug 16, 2018 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant