Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

attachment infos in csv export #17

Open
R-Zwi opened this issue Nov 20, 2024 · 1 comment · May be fixed by #20
Open

attachment infos in csv export #17

R-Zwi opened this issue Nov 20, 2024 · 1 comment · May be fixed by #20

Comments

@R-Zwi
Copy link

R-Zwi commented Nov 20, 2024 •
edited
Loading

There are some infos about attachments in the text export, but not yet in the csv export.

I did some modifications to add attachment infos to csv export.
The changes have a "works for me" state right now but I could beautify and provide them if it is of interest...

It creates an additional line in the output for each attachment (fourth field is 3).
Example:

1619164247433,1619164247445,19,3,0,"+436645647503","John","attachment-2021-04-23-09-50-47.jpg (image/jpeg, 110047 bytes, id 95-1619164179411)"
1619164247433,1619164247445,19,1,1,"+436645647503","John","Jim posted this"

The lines are added above the actual message because this is closer to how it is shown in the app.
@tbvdm
Copy link
Owner

tbvdm commented Nov 24, 2024

The changes have a "works for me" state right now but I could beautify and provide them if it is of interest...

Yes, that would be a useful addition.

The lines are added above the actual message because this is closer to how it is shown in the app.

True, but then again, the reaction lines are added below the message, so I think it would be more consistent to add the attachment lines below as well.

R-Zwi added a commit to R-Zwi/sigbak that referenced this issue Nov 26, 2024
@R-Zwi
add attachment infos to csv export
1296e83 
resolves tbvdm#17
@R-Zwi R-Zwi linked a pull request Nov 26, 2024 that will close this issue
Open
R-Zwi added a commit to R-Zwi/sigbak that referenced this issue Nov 26, 2024
@R-Zwi
add attachment infos to csv export
e484b6c 
resolves tbvdm#17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add attachment infos to csv export R-Zwi/sigbak
2 participants
@tbvdm @R-Zwi