This repository has been archived by the owner on Mar 17, 2021. It is now read-only.
TODO: Remove TaurusGui's "Manual" panel when Qt4 is no longer supported #1163
Labels
Comments
Open
jkotan
pushed a commit
to desy-fsec/taurus
that referenced
this issue
Jun 23, 2023
The TaurusMainWindow "Manual" Panel uses the deprecated QtWebkit.QWebView widget for displaying the manual, which is not directly available from PyQt5 or PySide. Replace it by its successor QtWebEngineWidgets.QWebEngineView Closes taurus-org#1163
jkotan
pushed a commit
to desy-fsec/taurus
that referenced
this issue
Jun 23, 2023
Use QWebEngineView for Manual Panel Closes taurus-org#1163 See merge request taurus-org/taurus!1209
jkotan
pushed a commit
to desy-fsec/taurus
that referenced
this issue
Jun 23, 2023
The TaurusMainWindow "Manual" Panel uses the deprecated QtWebkit.QWebView widget for displaying the manual, which is not directly available from PyQt5 or PySide. Replace it by its successor QtWebEngineWidgets.QWebEngineView Closes taurus-org#1163
jkotan
pushed a commit
to desy-fsec/taurus
that referenced
this issue
Jun 23, 2023
Use QWebEngineView for Manual Panel (2nd attempt) Closes taurus-org#1163 See merge request taurus-org/taurus!1213
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
"QWebkit is not available" message appears in the "Help->Manual" panel. This is because this panel was originally implemented simply as a
QWebkitbrowser showing the official documentation web page.In "modern" Qt versions
QWebkitis not available and a placeholder was left (it was not considered worth implementing a replacement).IMHO, this panel is not too useful and can simply be removed from the TaurusGui, but I prefer not to do it until we officially stop supporting the older Qt versions (it would be perceived as a regression for people still using them)
The text was updated successfully, but these errors were encountered: