Skip to content
This repository has been archived by the owner on Mar 17, 2021. It is now read-only.

TaurusGui export to xml fails #1129

Open
cpascual opened this issue Jul 14, 2020 · 0 comments
Open

TaurusGui export to xml fails #1129

cpascual opened this issue Jul 14, 2020 · 0 comments

Comments

@cpascual
Copy link
Member

Found while doing manual release tests in #1128

Testing the taurus gui actions I tried the "Tools->export current panel configuration to xml" and got this exception

Traceback (most recent call last):
  File "/home/cpascual/.virtualenvs/tmpJul20/lib/python3.7/site-packages/taurus/qt/qtgui/taurusgui/taurusgui.py", line 1737, in onExportCurrentPanelConfiguration
    panelxml = PanelDescription.fromPanel(panel).toXml()
  File "/home/cpascual/.virtualenvs/tmpJul20/lib/python3.7/site-packages/taurus/qt/qtgui/taurusgui/utils.py", line 429, in fromPanel
    icon=panel.icon,
AttributeError: 'DockWidgetPanel' object has no attribute 'icon'

Note: this may be related to #940 (because the Panel Description icon was added there)

jkotan pushed a commit to desy-fsec/taurus that referenced this issue Jun 23, 2023
Fixes taurus-org#1129

MR !940 broke the PanelDescription.fromPanel() when using panels
for which the new attributes were not described.

Make the "fromPanel" robust against this situation.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant