Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Serious Bug] It seems that I cannot quit from the animation after playing it long enough. #3

Open
nyngwang opened this issue Nov 29, 2022 · 11 comments

Comments

@nyngwang
Copy link

nyngwang commented Nov 29, 2022

As title. So I think it will be great if you could provide a config option in setup so that we can specify which key(s) we want to use to quit the animation.

  1. It says ... written, so I thought the obfuscated result were indeed saved. (but it doesn't, I know)
  2. I don't know how to jump back to the original buffer.

@nyngwang nyngwang changed the title It seems that I cannot quit from the animation after playing it long enough. [Serious Bug] It seems that I cannot quit from the animation after playing it long enough. Nov 29, 2022
@tamton-aquib
Copy link
Owner

I think it will be great if you could provide a config option in setup so that we can specify which key(s) we want to use to quit the animation.

True. will add it shortly 😅

@nyngwang
Copy link
Author

nyngwang commented Nov 29, 2022

@tamton-aquib Here is the config I used for the testing: (i.e. I was passing {} into the setup, instead of calling setup())

config = function() require('zone').setup {} end

Trying

and regarding the point:

  1. I don't know how to jump back to the original buffer.

This is indeed a serious bug. I cannot get rid of the obfuscated result, and it covers the source buffer. I did try <Esc>, <C-c>, <C-o>, but still cannot get rid of it. Because of this, I have to temporarily remove this plugin.

Reasoning

I was thinking about whether there might be some conflict(s) between zone.nvim and my existing plugins. I guess the culprit might be related to the async. behaviour of vim.schedule (but I'm not sure!) Might be you could start from here.

@tamton-aquib
Copy link
Owner

Hey, I've been fiddling around but haven't stumbled upon this type of bug yet 🤔 .

Also I tried setting keymap for <Esc> but it isnt working for some reason (prolly all the scheduling and stuff)
Can u try with a minimal config? Or can u share ur config so i can try in my free time? 😅

@nyngwang
Copy link
Author

nyngwang commented Dec 3, 2022

I just experienced this again, let me show you what it looks like:

demo_zone_bug.mov

The details about my steps to reproduce it (always run into this situation):

  1. Let the animation run.
  2. Switch to my favorite browser and do something else.
  3. After like 5 mins, then switch back. The animation did stop but didn't get canceled (I've tried both arrow keys and <Esc>). As you can see from the demo, I was able to switch my cursor to the filetree window(as it printed neo-tree) but the content of that window was covered by the frozen animation.

So, I didn't exaggerate this problem. People will not be able to continue their work after they switch back to their terminal emulator. My current solution is to simply uninstall it before it will be updated into a stable one. (I trust you)

[...] Or can u share ur config so i can try in my free time?

Sorry I cannot share my config since it's a private Repo. As I mentioned in the previous comment I didn't do anything special about zone.nvim's setup. I guess the culprit is probably the filetree plugin neo-tree.nvim I'm using.

@tamton-aquib
Copy link
Owner

Ah, thanks for the detailed info 😄.

Last question: Does it happen with other styles? or is it just treadmill?

@nyngwang
Copy link
Author

nyngwang commented Dec 4, 2022

@tamton-aquib I just tried epilepsy and my cursor got frozen and neovim became very laggy when it happen:

Epilepsy_frozen.mov

@tamton-aquib
Copy link
Owner

Ah i see, thanks for taking the time to test it. I'll get on it soon.

@tamton-aquib
Copy link
Owner

Heyyo @nyngwang,

So I have been migrating from the normal getting and setting lines to extmark.
The performance has greatly improved in my system.

About the keybind,
As the plugin is creating a floating window without entering, we cannot set buffer local keymappings 😅 .
But the CursorMoved autocmd exists btw.

I have also excluded some filetypes like neotree so it might be an improvement.

Sorry for being late btw, was caught up in other works 😄

@daUnknownCoder
Copy link

hey @tamton-aquib i encountered it too and there's another problem, it doesn stop with insert mode, :w, q idk why and for me it flickers too
image

@daUnknownCoder
Copy link

demo_zone_bug.mov

ur bufferline looks sick can i get its config? @nyngwang

tamton-aquib added a commit that referenced this issue Mar 10, 2024
@tamton-aquib
Copy link
Owner

I have pushed a temporary fix for this issue, please update and let me know 😅 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants