Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pricing bug in AWS Cloudwatch and hardcoded zero cost in some of the aws products #1298

Closed
srikar-jilugu opened this issue Dec 26, 2023 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@srikar-jilugu
Copy link

srikar-jilugu commented Dec 26, 2023

Describe the bug

Inaccurate Cost information for various aws products:

I was testing komiser on an aws account by setting it up in an ec2-instance using komiser cli and attached the necessary polices provided in policy.json to the corresponding iam role.

  • Inaccurate Cloudwatch cost:
Screenshot 2023-12-26 at 7 09 42 PM

this is a cloudwatch alarm and its cost is reported as 219$ per month, but as per cloudwatch pricing it should be only 0.3$ per month, seems like the cost calculation considers this pricing plan as "per hour" as it calculates here in the code(0.3*730=219$)

Screenshot 2023-12-26 at 7 18 52 PM
  • Hardcoded cost as 0 for RDS, ECS and some other products:
    I can see the cost is returned as 0 in some of the products, it seems like cost computation is not yet integrated for these products but including these products in the inventory is giving false information to the overall cost breakup.
Screenshot 2023-12-26 at 5 28 31 PM

To Reproduce
Steps to reproduce the behavior:

  1. Installed komiser cli on ec2-instance (also tried with docker compose using the image tailwarden/komiser:3.1.6
  2. created config.toml file to get aws account credentials from ENVIRONMENT_VARIABLES

Expected behavior

  • Cost Breakup of the account being inaccurate when compared to Aws Cost Explorer

Screenshots
If applicable, add screenshots or Loom video to help explain your problem.

Desktop (please complete the following information):

  • OS: MacOS 13.5
  • Browser: Chrome
  • Version: latest

Very Impressed by this project btw!

@srikar-jilugu srikar-jilugu added the bug Something isn't working label Dec 26, 2023
Copy link

Hey, thank you for opening your first Issue! 🙂 While a Tailwarden team member takes a look at your issue we would like to invite you to join our official Discord server, where you can interact directly with other contributors and Tailwarden team members. Link here: https://discord.tailwarden.com

@AvineshTripathi
Copy link
Collaborator

Hey @srikar-jilugu thanks for notifying us will fix this soon in coming releases.

@bishal7679
Copy link
Contributor

@AvineshTripathi Assign me!
I will look into it

@Azanul
Copy link
Collaborator

Azanul commented Mar 2, 2024

Hi @bishal7679, is there an update on this?

@Azanul
Copy link
Collaborator

Azanul commented Mar 8, 2024

Closing this issue for the following reasons:

  • Cloudwatch bug has been fixed, we now use pricing output to calculate cost.
  • Hardcoded costs are hardcoded as 0 because each resource under every service doesn't have a cost associated with it.

Feel free to reopen if you notice otherwise.

@Azanul Azanul closed this as completed Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants