-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use doctr #64
Comments
It does matter. The point of doctr is to manage the deploy keys. Travis CI has a special public/private key pair for each repository, which we use to encrypt an SSH deploy key for pushing to GitHub pages. This is 90% of what doctr does, and the main reason that I wrote it, because it's such a pain to do this manually all the time (the other 90% is managing the syncing of files). GitLab hopefully has something similar, or (better), a way to upload SSH keys directly. |
@asmeurer the way I've done it, for both Travis and GitLab-CI is to literally paste the (base64 encoded) private ssh key as a private variable (at either Travis or GitLab) and it then gets passed into the script as a variable. So it's simple, and as secure as your solution. |
Yeah. The point of doctr is to do that automatically, using the API. So you don't have to go in and paste stuff in websites. You just run one command ( |
Using
doctr
might simplify quite a few lines in our deploy script:https://github.com/drdoctr/doctr
@asmeurer mentioned that perhaps drdoctr/doctr#189 must be fixed first, though perhaps not, since we actually run this inside Docker, and whether the docker container is run on Travis-CI or GitLab-CI makes no difference to the code within.
The text was updated successfully, but these errors were encountered: