Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use doctr #64

Open
certik opened this issue Jun 5, 2017 · 3 comments
Open

Use doctr #64

certik opened this issue Jun 5, 2017 · 3 comments

Comments

@certik
Copy link
Member

certik commented Jun 5, 2017

Using doctr might simplify quite a few lines in our deploy script:

https://github.com/drdoctr/doctr

@asmeurer mentioned that perhaps drdoctr/doctr#189 must be fixed first, though perhaps not, since we actually run this inside Docker, and whether the docker container is run on Travis-CI or GitLab-CI makes no difference to the code within.

@asmeurer
Copy link
Member

asmeurer commented Jun 5, 2017

It does matter. The point of doctr is to manage the deploy keys. Travis CI has a special public/private key pair for each repository, which we use to encrypt an SSH deploy key for pushing to GitHub pages. This is 90% of what doctr does, and the main reason that I wrote it, because it's such a pain to do this manually all the time (the other 90% is managing the syncing of files).

GitLab hopefully has something similar, or (better), a way to upload SSH keys directly.

@certik
Copy link
Member Author

certik commented Jun 5, 2017

@asmeurer the way I've done it, for both Travis and GitLab-CI is to literally paste the (base64 encoded) private ssh key as a private variable (at either Travis or GitLab) and it then gets passed into the script as a variable. So it's simple, and as secure as your solution.

@asmeurer
Copy link
Member

asmeurer commented Jun 5, 2017

Yeah. The point of doctr is to do that automatically, using the API. So you don't have to go in and paste stuff in websites. You just run one command (doctr configure), enter your username and password, and it's all done automatically. Then the only thing you have to do manually is add the encrypted key to the .travis.yml (for GitLab, nothing would have to be done manually).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants