Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GPS Validity Check to Use mode Instead of status Field #50

Open
danthony06 opened this issue Oct 26, 2021 · 2 comments
Open

Update GPS Validity Check to Use mode Instead of status Field #50

danthony06 opened this issue Oct 26, 2021 · 2 comments

Comments

@danthony06
Copy link
Collaborator

danthony06 commented Oct 26, 2021

Rather than checking the status field for the fix validity, we should be looking at the mode field. These fields are described here: https://gpsd.gitlab.io/gpsd/gpsd_json.html. Currently, the checks on the status field will work correctly with basic GPS receivers, but may not work with RTK, DGPS, or other receivers, and may report that we do not have a fix, even if the receivers are working correctly. This change will bring us closer to how GPSD is intended to be used, and will also help resolve issues with the status values changing between gpsd releases that we're continuously putting ifdef statements in for.

This will become especially important around gpsd v3.23 gets released, as the status fields have significantly changed, and the conditionally compiling around them will be quite ugly. It will also allow us to remove many of the ifdef statements that are littering the code and making it challenging to read and maintain.

@danthony06 danthony06 changed the title Update GPS Validity Check to Use mode Instead of Status Field Update GPS Validity Check to Use mode Instead of status Field Oct 26, 2021
@danthony06
Copy link
Collaborator Author

@pjreed I'd also like your opinion on the matter since you maintained it for so long. I think we've seen requests for things like DGPS support in the past that this would address.

@danthony06
Copy link
Collaborator Author

Or if @kriskozak has strong opinions, I'd like to hear them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant