You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Rather than checking the status field for the fix validity, we should be looking at the mode field. These fields are described here: https://gpsd.gitlab.io/gpsd/gpsd_json.html. Currently, the checks on the status field will work correctly with basic GPS receivers, but may not work with RTK, DGPS, or other receivers, and may report that we do not have a fix, even if the receivers are working correctly. This change will bring us closer to how GPSD is intended to be used, and will also help resolve issues with the status values changing between gpsd releases that we're continuously putting ifdef statements in for.
This will become especially important around gpsd v3.23 gets released, as the status fields have significantly changed, and the conditionally compiling around them will be quite ugly. It will also allow us to remove many of the ifdef statements that are littering the code and making it challenging to read and maintain.
The text was updated successfully, but these errors were encountered:
danthony06
changed the title
Update GPS Validity Check to Use mode Instead of Status Field
Update GPS Validity Check to Use mode Instead of status Field
Oct 26, 2021
@pjreed I'd also like your opinion on the matter since you maintained it for so long. I think we've seen requests for things like DGPS support in the past that this would address.
Rather than checking the
status
field for the fix validity, we should be looking at themode
field. These fields are described here: https://gpsd.gitlab.io/gpsd/gpsd_json.html. Currently, the checks on thestatus
field will work correctly with basic GPS receivers, but may not work with RTK, DGPS, or other receivers, and may report that we do not have a fix, even if the receivers are working correctly. This change will bring us closer to how GPSD is intended to be used, and will also help resolve issues with thestatus
values changing between gpsd releases that we're continuously puttingifdef
statements in for.This will become especially important around gpsd v3.23 gets released, as the status fields have significantly changed, and the conditionally compiling around them will be quite ugly. It will also allow us to remove many of the
ifdef
statements that are littering the code and making it challenging to read and maintain.The text was updated successfully, but these errors were encountered: