Skip to content
This repository has been archived by the owner on Aug 24, 2018. It is now read-only.

Why are we only returning definitionsFullyResolved and ignoring definitions? #5

Open
ponelat opened this issue Feb 23, 2016 · 5 comments

Comments

@ponelat
Copy link
Member

ponelat commented Feb 23, 2016

I referring to this... https://github.com/swagger-api/sway-worker/blob/master/index.js#L28-L39
If there are errors we return either defintionsFullyResolved or defintions
If there are no errors we only return defintionsFullyResolved

Is this intentional? I'm curious, because defintionsFullyResolved isn't populate in my case. Could this be a sway issue?

@mohsen1
Copy link
Collaborator

mohsen1 commented Feb 23, 2016

@whitlockjc can you comment on this?

@whitlockjc
Copy link

The only reason definitionFullyResolved doesn't get populated is if JsonRefs#resolveRefs fails. Update your Sway.create(...).catch(function (err) { console.log(err.stack); }); to see what is up.

@ponelat
Copy link
Member Author

ponelat commented Feb 23, 2016

ok, thanks I will. And if its interesting, I'll post back.

@whitlockjc
Copy link

Let me know if I can help.

@ponelat
Copy link
Member Author

ponelat commented Feb 23, 2016

Bah, I can't get my system to work, I'n going to bed.
@whitlockjc I'll see if I can't reproduce my case, and see what is happening... its most likely my configuration of the projects that's tripping me up.

Thanks for the help, @mohsen1 @whitlockjc

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants