Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bloated and no longer required string.prototype.matchall dependency #58

Open
ulrichstark opened this issue Dec 31, 2023 · 1 comment · May be fixed by #60
Open

Remove bloated and no longer required string.prototype.matchall dependency #58

ulrichstark opened this issue Dec 31, 2023 · 1 comment · May be fixed by #60

Comments

@ulrichstark
Copy link

The string.prototype.matchall dependency to implement String.prototype.matchAll() in Node v10 was added because "The Workbox project [...] need to continue support Node v10 until our next major release version" (see #49).
workbox-build is now on version 7.0.0 and has a minimum supported Node version of v16.
String.prototype.matchAll() is available in Node since v12 according to MDN.
The dependency tree of string.prototype.matchall is bloated, so i would like to have it removed as the polyfill is no longer required by the most recent workbox-build version.

Dependency tree of string.prototype.matchall:
image

This screenshot is from an internal tool to analyze the package-lock.json file.
Dependencies starting from the second level below string.prototype.matchall are collapsed for better readability.
Removing no longer required dependency string.prototype.matchall would save users of this package from installing a lot of packages.

@donmccurdy donmccurdy linked a pull request Jun 23, 2024 that will close this issue
@donmccurdy
Copy link

I agree with @ulrichstark, and would be glad to trim the extra dependencies — I've opened a PR:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants