Skip to content
This repository has been archived by the owner on Dec 27, 2021. It is now read-only.

proto annotations for identifying entity ID #171

Open
zenyui opened this issue Sep 4, 2020 · 2 comments
Open

proto annotations for identifying entity ID #171

zenyui opened this issue Sep 4, 2020 · 2 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed ideation In brainstorming session

Comments

@zenyui
Copy link
Contributor

zenyui commented Sep 4, 2020

Is your feature request related to a problem? Please describe.
we deprecated the feature to invoke sendcommand and automatically identify the entity ID. we should add it back.

Describe the solution you'd like
a well-known annotation (or configuration) that allows lagom-pb to infer the entity ID based on the field descriptor / message.

Describe alternatives you've considered
n/a

Additional context
n/a

@Tochemey Tochemey added this to the v1.0.0 milestone Sep 4, 2020
@Tochemey Tochemey self-assigned this Sep 4, 2020
@zenyui
Copy link
Contributor Author

zenyui commented Sep 5, 2020

let's eject his from v1.0 until we have better examples. until then, i'd rather just use annotations for validations.

@zenyui zenyui removed this from the v1.0.0 milestone Sep 5, 2020
@Tochemey
Copy link
Contributor

Tochemey commented Sep 5, 2020

let's eject his from v1.0 until we have better examples. until then, i'd rather just use annotations for validations.

It does make sense

@Tochemey Tochemey added enhancement New feature or request ideation In brainstorming session help wanted Extra attention is needed labels Nov 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request help wanted Extra attention is needed ideation In brainstorming session
Projects
None yet
Development

No branches or pull requests

2 participants