Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for gsol transfers and mint #4

Open
dankelleher opened this issue May 31, 2023 · 0 comments
Open

Fix for gsol transfers and mint #4

dankelleher opened this issue May 31, 2023 · 0 comments

Comments

@dankelleher
Copy link
Member

The code here https://github.com/sunrise-stake/transaction-monitor/blob/master/index.js#L12 seems to be wrong.

To reiterate the requirement from the original ticket, the db needs to be populated with:

  • gsol token mints (GSOL is a fungible SPL-token, not an NFT). They look like this
  • gsol token transfers, that look like this

We have these already, but what we also need to do is recognise transfers that are part of CPIs, for example NFT purchases like this.

However, we should not be specific to any particular nft sale, as seems to be the mistake in the original code.

Also, this code needs to be flexible and easy to change. Different strategies should be easy to plug in. For example, we may want to exclude transfer CPIs triggered by a defi protocol like jupiter, or start putting nft purchases in a different table, for example. So the existing code should be refactored to allow this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant