Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODOs before Submitting as an EIP #1

Open
5 tasks done
adrianmcli opened this issue Aug 29, 2023 · 1 comment
Open
5 tasks done

TODOs before Submitting as an EIP #1

adrianmcli opened this issue Aug 29, 2023 · 1 comment

Comments

@adrianmcli
Copy link
Collaborator

adrianmcli commented Aug 29, 2023

TODOs as of 2023-10-19:

  1. Authorship Clarification: Discuss and decide who should be listed as authors based on their contributions.
  2. Core Circuits Expansion: Provide more details on the core circuits within the Specification section.
  3. Test Cases Addition:
    • Include tests for function inputs, both valid and invalid.
    • Test event emissions for correctness.
    • Test the ZK proof verification functionality.
  4. Security Considerations Expansion:
    • Detail potential risks and mitigation strategies concerning ZK proofs implementation.
    • Address security implications of off-chain verification.
    • Discuss error handling and potential exploitation by malicious actors.
    • Address dependency security and potential reentrancy attacks.
  5. Placeholder Text Removal: Replace or remove all placeholder text throughout the document.
  6. Community Engagement: Engage with the community on the provided discussion link to gather feedback.
  7. Final Compliance Review: Conduct a final review to ensure the document complies with EIP-1 guidelines.

Initial Steps (for reference)

According to the official README of the EIPs repo, we need to do the following:

  • Discuss the idea on Ethereum Magicians.
  • Read over EIP-1 for instructions on creating an EIP.
  • Create a draft with the necessary headings.
  • Fill out each section.
  • Get feedback, and iterate.

Let's also keep this in mind:

It is highly recommended that a single EIP contain a single key proposal or new idea. The more focused the EIP, the more successful it tends to be.

@enricobottazzi enricobottazzi moved this to Spec'ing in ∑ Summa Aug 31, 2023
@adrianmcli adrianmcli changed the title First Steps TODOs before Submitting as an EIP Oct 20, 2023
@adrianmcli
Copy link
Collaborator Author

I have created 4 more issues to detail things that need to be complete before we submit the PR for an EIP number:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Spec'ing
Development

No branches or pull requests

1 participant