Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue 3 compatibility #78

Open
adambartosiewicz opened this issue Jan 22, 2021 · 14 comments
Open

Vue 3 compatibility #78

adambartosiewicz opened this issue Jan 22, 2021 · 14 comments
Labels
enhancement New feature or request

Comments

@adambartosiewicz
Copy link

Any plans for updating the code to be compatible with Vue 3?

@MrWook
Copy link
Collaborator

MrWook commented Jan 22, 2021

Hey good question.

Currently i'm mainly working with nuxt which is not compatible with vue3 yet this means i'm not really into vue3 at the moment but i know there is a library that will build a vue3 compatible file out of a vue2 library i just don't know how it is called anymore. If i find it again, i will check it out.

@mst101 is constantly improving this package and is in the process of adding keyboard support.
This means that i will definitely wait till he finishes it because that is a big complicated feature.

@MrWook MrWook added the enhancement New feature or request label Jan 22, 2021
@hisuwh
Copy link

hisuwh commented Nov 26, 2021

@MrWook are you thinking of vue-demi?

@wadday
Copy link

wadday commented Jan 25, 2022

here is a snapshot of vuejs-datepicker implemented for Vue 3. uses all the functionalities in vuejs-datepicker.

my main objective was to workaround to use in Vue 3 however, during the implementation I've also added one of the biggest issues I had on my office project. On day views every month numbers of days are different and the picker resizes the height accordingly.

Day view Month View Year View
image image image

currently, this is not on a public repository, however, if anyone wants to contribute to making this as a package, I am ready to push to GitHub.

@hisuwh
Copy link

hisuwh commented Jan 25, 2022

@wadday is this something you have been developing separately to this package?

@wadday
Copy link

wadday commented Jan 28, 2022

@wadday is this something you have been developing separately to this package?

Idea is to make it public as a separate package for Vue 3. However, my schedule is very tight at the moment.

@wadday
Copy link

wadday commented Feb 22, 2022

those who are looking for Vue 3 version check this out. https://github.com/shubhadip/vuejs3-datepicker

@acallaghan
Copy link

Any movement on Vue 3 @MrWook? Nuxt is compatible with Vue 3 now

@acallaghan
Copy link

Ah i see this commit - 46bab51

Let me know if you need any help at all, happy to help out here

@brandonburkett
Copy link

We're finally making the vue3 upgrade soon. Is this still a pending feature or will it become a separate package?

@mst101
Copy link
Contributor

mst101 commented Sep 28, 2022

I've been a bit distracted recently learning Nuxt (which I'm enjoying very much...), but I have also been working locally on upgrading this project to Vue 3. It's working, but I still have issues with getting some unit tests to pass. There's also more to be done with setting up a v3 version of the e2e tests + the actual build.

I will upload my work-in-progress asap - and will welcome any help you (@acallaghan, @brandonburkett, or others - and of course @MrWook) may be able to provide to get v3 off the ground!

@mst101
Copy link
Contributor

mst101 commented Oct 19, 2022

Please see #185. We're getting there, but I could do with some help getting these 6 unit tests to pass!

@mst101
Copy link
Contributor

mst101 commented Nov 1, 2022

Good news! All tests are all passing now - upgrading vue-test-utils from v2.1 to v2.2 solves the problem.

All that's left now (as far as I'm aware) is to update the Cleave & Vee-validate integrations in Vuepress 2 docs...

@brandonburkett
Copy link

Our vue3 transition got pushed until next month, but can help check how it works in our env then.

@roelVerdonschot
Copy link

Any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

8 participants