Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poppy upgrade: Investigate using instance.complete_updated_date to replace instance/holdings/items join #1332

Closed
cbeer opened this issue Feb 8, 2024 · 4 comments · Fixed by #1334
Assignees
Labels

Comments

@cbeer
Copy link
Member

cbeer commented Feb 8, 2024

Possibly fixes #980

@cbeer cbeer added the folio label Feb 8, 2024
@hudajkhan
Copy link
Contributor

hudajkhan commented Feb 8, 2024

Seems like: Poppy added field for timestamp on instance reflecting whether holdings/items have changed.
We need to assess if that is in fact true, and then see if we can use the Poppy info to save some indexing work.

May also require assessing impact on indexing memory issues.

@dnoneill
Copy link
Contributor

dnoneill commented Feb 8, 2024

See comment #1310

@dnoneill dnoneill self-assigned this Feb 8, 2024
@dnoneill
Copy link
Contributor

dnoneill commented Feb 8, 2024

Tests completed

  • changing properties on the instance
  • changing properties on a holdings record
  • changing properties on an item
  • transferring an item between holdings
    with caveat. The record with the moved item does not update. Alissa has informed me this is a know issue with folio currently and record editors know to update the record with the moved item so that it does trigger.
  • transferring a holdings record between instances
    Same caveat. The record with the moved holding doesn't update.
  • changing marc records
  • changing course reserves information (been tested, did not work correctly)

Based on the caveats this does not fix #980 but it does allow us to clean up some code.

@dnoneill
Copy link
Contributor

dnoneill commented Feb 8, 2024

Couple of things that came up with exploring the data:

table Number of rows per table How to access instance
sul_mod_inventory_storage.instance 10,284,710 n/a
sul_mod_inventory_storage.holdings_record 12,366,458 instanceid field
sul_mod_inventory_storage.items 11,429,559 holdingsrecordid field

One odd thing about the holdings_record is there doesn't seem to be any empty instanceid fields (assuming I queried correctly). Some holdings have same instanceids (see WHERE instanceid = '6b68aea8-2230-52a9-b008-ce8f21309f90')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants