update bce calculation #148
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please provide a little more context (perhaps a before/after comparison). thanks |
|
@hudajkhan I am not quite sure what more context you would like. Could you give me an example? The description includes examples. |
|
@dnoneill reading it over again, I'm not sure what it was I meant by the comment. I'll look over the details again and ask if I have any questions, but I think you are correct that the necessary information is included in the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes sul-dlss/searchworks_traject_indexer#1319
This addresses that in order to be able to sort dates bce dates (https://searchworks.stanford.edu/view/qb122dq4313.json) with dates like 19xx 195x the date gets converted to a string. When sorting a negative string i.e. "-1" = 1 BCE, "-2" = BCE these would get sorted -1,-2 when they should get sorted -2, -1. See
stanford-mods/lib/stanford-mods/concerns/origin_info.rb
Lines 40 to 46 in 19af5eb
The current branch subtracts -1000 from the absolute value (i.e. 1-1000 = -999). This is a problem for larger BCE dates which return 6000 and not a negative number. The fix is to increase this number.