Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add presentation data to external resource #757

Open
jcoyne opened this issue Jul 15, 2024 · 1 comment
Open

Add presentation data to external resource #757

jcoyne opened this issue Jul 15, 2024 · 1 comment

Comments

@jcoyne
Copy link
Contributor

jcoyne commented Jul 15, 2024

There is a test in this suite that creates an external resource with no image data. This causes HB to log a notice, which is a distraction. Ideally it would create proper data so that we don't get the notification.

https://app.honeybadger.io/projects/48916/faults/108092570

[Data Error] External resource has no presentation data

@andrewjbtw
Copy link

I believe this will require supplying image dimensions via sdr-api or some alternative method. This test puts images directly through accessionWF, which does not have the exif metadata extraction step that assemblyWF uses to generate this metadata. Alternatively, the test could send items through assemblyWF.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants