From 7b9e9746111d1ecb96a8faa2158154dbb08d1173 Mon Sep 17 00:00:00 2001 From: Evan Theurer Date: Thu, 7 Jan 2016 17:40:32 +0100 Subject: [PATCH] Keep dialog from displaying when installation of the chrome screensharing extension is declined (FS#1696). --- static/js/directives/screenshare.js | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/static/js/directives/screenshare.js b/static/js/directives/screenshare.js index 58e73dd7f..6667349a4 100644 --- a/static/js/directives/screenshare.js +++ b/static/js/directives/screenshare.js @@ -180,8 +180,21 @@ define(['jquery', 'underscore', 'text!partials/screenshare.html', 'text!partials $scope.stopScreenshare(); } }, function(err) { - console.log("Screen sharing request returned error", err); - alertify.dialog.alert(translation._("Failed to start screen sharing (%s).", err)); + var errMsg = ''; + var errCode = ''; + if (err && err.detail) { + errMsg = err.detail; + errCode = err.errorCode; + } else { + errMsg = err; + } + console.log("Screen sharing request returned error", errMsg); + // Do not display error dialog when user cancelled action of + // chrome extension installation + // https://developer.chrome.com/extensions/webstore#type-ErrorCode + if (errCode !== 'userCancelled') { + alertify.dialog.alert(translation._("Failed to start screen sharing (%s).", errMsg)); + } $scope.stopScreenshare(); });