Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow_redisplay not supported in collectPaymentMethod contrary to docs #858

Open
rsanchez opened this issue Dec 3, 2024 · 2 comments
Open

Comments

@rsanchez
Copy link

rsanchez commented Dec 3, 2024

Describe the bug
The "Save after payment" doc (https://docs.stripe.com/terminal/features/saving-cards/save-after-payment?terminal-sdk-platform=react-native#collect-payment-method) shows this example:

const { paymentIntent, error } = await collectPaymentMethod({
  paymentIntentId: paymentIntentId,
  allow_redisplay: "always",
});

if (error) {
  // Placeholder for handling exception
  return;
}

But this produces a Typescript error: Object literal may only specify known properties, and 'allow_redisplay' does not exist in type 'CollectPaymentMethodParams'.

Stripe recently issued new guidance via email with subject line "[Action required] Update to consent collection when saving cards on Terminal", which states "You’ll also need to pass allow_redisplay as always or limited via your Terminal SDK..."

To Reproduce
Steps to reproduce the behavior:

  1. Open the example-app
  2. Add allow_redisplay: "always" as an argument to collectPaymentMethod in CollectCardPaymentScreen
  3. See the Typescript error in VS Code

Expected behavior
The allow_redisplay should be supported when creating a PaymentMethod via the Terminal SDK.

Stripe Terminal React Native SDK version

  • ^0.0.1-beta.23
@nazli-stripe
Copy link
Collaborator

Ah allow_redisplay was introduced on SDK v4, which we'll upgrade RN SDK to in early January. Looks like we edited the docs a bit too soon, is not being able to use it causing you issues right now?

@rsanchez
Copy link
Author

rsanchez commented Dec 3, 2024

Not causing issues right now. Stripe says we have until March 31, 2025 to comply with these new requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants