Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Grab strategy #17

Open
Vincent-Beltman-Inspiro opened this issue Nov 14, 2024 · 2 comments
Open

Feature request: Grab strategy #17

Vincent-Beltman-Inspiro opened this issue Nov 14, 2024 · 2 comments

Comments

@Vincent-Beltman-Inspiro
Copy link
Contributor

The C++ SDK offers the option to choose between various grab strategies. Which uses this enum.
Could you add this option or instruct me how this should be added?

@astraw
Copy link
Member

astraw commented Nov 14, 2024

My suggestion is to use TimeoutHandling, from the C++ and Rust sides, as an example of how to wrap a C++ enum in Rust. Then expand the Rust GrabOptions struct to have a grab_strategy: Option<GrabStrategy> field where this defaults to None. Hopefully we can add a way to build a rust GrabStrategy struct without requiring a semver bump.

@Vincent-Beltman-Inspiro
Copy link
Contributor Author

@astraw Created a PR: #18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants