fix(on_result_diagnostic): treat end_lnum < 1 as unitialized
#396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruslanSorokin
force-pushed
the
fix/no-ref/check-end_lnum-bounds-as-1-indexed
branch
from
f42e163 to
476d400
Compare
The end of the diagnostic range was previously calculated as `item.end_lnum and item.end_lnum - 1`. Given `item = { lnum: 95, end_lnum: 0, ... }`, this calculation would span everything from the beginning up to line 95. I believe that an `end_lnum` value of zero should be treated as uninitialized (because lines are 1-indexed). Therefore, I think the item should be considered a single-line item.
ruslanSorokin
force-pushed
the
fix/no-ref/check-end_lnum-bounds-as-1-indexed
branch
from
476d400 to
b6d5352
Compare
stevearc
requested changes
Jan 12, 2025
| @@ -68,7 +68,7 @@ local comp = { | |||
| message = item.text, | |||
| severity = type_to_severity[item.type] or vim.diagnostic.severity.ERROR, | |||
| lnum = (item.lnum or 1) - 1, | |||
| end_lnum = item.end_lnum and (item.end_lnum - 1), | |||
| end_lnum = (item.end_lnum and item.end_lnum > 0) and (item.end_lnum - 1) or item.lnum, | |||
There was a problem hiding this comment.
This is starting to get beyond what is readable for a single line. Can you refactor into multiple lines above?
There was a problem hiding this comment.
Thank you for the feedback! I've gotten rid of the ternary operator for better readability as requested and also made it explicit that an uninitialized end_lnum gets value of lnum + 1. Let me know if further adjustments are needed!
|
LGTM, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The end of the diagnostic range was previously calculated as
item.end_lnum and item.end_lnum - 1. Givenitem = { lnum: 95, end_lnum: 0, ... }, this calculation would span everything from the beginning up to line 95. I believe that anend_lnumvalue of zero should be treated as uninitialized (because lines are 1-indexed). Therefore, I think the item should be considered a single-line item.