Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shiny 1.8.1 release breaks statnetWeb #86

Closed
martinamorris opened this issue Jul 12, 2024 · 0 comments
Closed

shiny 1.8.1 release breaks statnetWeb #86

martinamorris opened this issue Jul 12, 2024 · 0 comments

Comments

@martinamorris
Copy link
Member

The two changes are detailed in the release notes and they are:

  • renderDataTable()/dataTableOutput() are officially deprecated in favor of their {DT} equivalents. Migrating to {DT}, in most cases, just requires changing renderDataTable() to DT::renderDT() and dataTableOutput() to DT::DTOutput().

    This is an easy fix. Both functions were used a couple of times in the ui.R file.

  • Both conditionalPanel() and uiOutput() are now styled with display: contents by default in Shiny apps that use Bootstrap 5.

    They note that this will break apps that use these functions directly, and sW does use both -- many times -- in ui.R. Not clear what the fix is for this. Have posted a question on the change commit to see if they can send a quick fix.

@mbojan any chance you know how to fix our code to address that second change?

@martinamorris martinamorris changed the title shiny 1.8.1.1 release breaks statnetWeb shiny 1.8.1 release breaks statnetWeb Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant