[5.x] Changing Stache index name from collection to collectionHandle #11324
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11323
A chain of though here ....
EntryQueryBuilder.php
:When someone does a collection query
{{ collection:blog }}
(Entry::query()->where('collection', 'blog')
), thecollection
condition is intercepted and stored in a separate$collections
property instead of being handled as a normal where clause.EntryQueryBuilder.php
:The code explicitly uses 'collectionHandle' because it needs to bypass the interception of 'collection' queries that happens in the where() method.
Seems like we should only have 'collectionHandle' because:
I hope Im right here ...