From 06629361d48b60b9ed3bf631aa2d487fc2d6dc7f Mon Sep 17 00:00:00 2001 From: AvivYossef-starkware Date: Wed, 10 Jul 2024 15:51:41 +0300 Subject: [PATCH] fix: invalid version format commit-id:776e06e7 --- .../blockifier/src/transaction/error_format_test.rs | 12 ++++++++++++ crates/blockifier/src/transaction/errors.rs | 4 ++-- 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/crates/blockifier/src/transaction/error_format_test.rs b/crates/blockifier/src/transaction/error_format_test.rs index 844c884499..20c6be4054 100644 --- a/crates/blockifier/src/transaction/error_format_test.rs +++ b/crates/blockifier/src/transaction/error_format_test.rs @@ -27,3 +27,15 @@ fn test_declare_transaction_error_format() { already declared." ); } + +#[test] +fn test_invalid_version_format() { + let error = TransactionExecutionError::InvalidVersion { + version: TransactionVersion::THREE, + allowed_versions: vec![TransactionVersion::ONE, TransactionVersion::TWO], + }; + assert_eq!( + error.to_string(), + "Transaction version 0x3 is not supported. Supported versions: [0x1, 0x2]." + ); +} diff --git a/crates/blockifier/src/transaction/errors.rs b/crates/blockifier/src/transaction/errors.rs index 30e050456e..0edbba53c5 100644 --- a/crates/blockifier/src/transaction/errors.rs +++ b/crates/blockifier/src/transaction/errors.rs @@ -78,8 +78,8 @@ pub enum TransactionExecutionError { #[error("The `validate` entry point should return `VALID`. Got {actual:?}.")] InvalidValidateReturnData { actual: Retdata }, #[error( - "Transaction version {version:?} is not supported. Supported versions: \ - {allowed_versions:?}." + "Transaction version {:?} is not supported. Supported versions: \ + {:?}.", **version, allowed_versions.iter().map(|v| **v).collect::>() )] InvalidVersion { version: TransactionVersion, allowed_versions: Vec }, #[error(transparent)]