-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support writing FIT files #33
Comments
Hi @wtchen I’m not opposed to the idea. I simply didn’t have a personal use case for writing files or the time to commit to it. I suspect to write files we’ll need something like #14 implemented as well to make a more friendly API. Although the data structures returned by reading probably could work just as well but provide less built in type safety. |
@stadelmanma Thanks for getting back to me, glad to communicate with you. Personally, I think it would be useful to use for scripts where I can edit my FIT files. It would be nice if I can edit out a faulty data point without having to use an intermediate format. I would probably inclined to use the existing data structures. From a glance, they seem to be more than good enough 🙂 I'm happy to start on this, though I would have to work on this piecemeal on weekends. Perhaps you can create a branch I can submit PRs to? Or I'm glad to accommodate however you'd like me to submit features related to this. |
Hi @wtchen simply forking this repo and opening up a draft PR would work well enough to collaborate on changes. Sorry for the delay I thought I had responded already. |
Adding a note here based on discussion in #47. When serializing FIT files from library data we will need to assert that any instances of |
Adding encoding support would open up this library to a number of new uses, such as data collection (e.g. sport watches etc) and file conversion. It would also distinguish this library from others, most of which don't provide any encoding support.
We could use tormoder's Go library as a reference implementation. I'm happy to help work on this over time.
The text was updated successfully, but these errors were encountered: