Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Ensure we check for nonempty pre-sign requests #1189

Closed
1 task
djordon opened this issue Jan 8, 2025 · 0 comments · Fixed by #1190
Closed
1 task

[Bug]: Ensure we check for nonempty pre-sign requests #1189

djordon opened this issue Jan 8, 2025 · 0 comments · Fixed by #1190
Assignees
Labels
bug Something isn't working sbtc signer binary The sBTC Bootstrap Signer.

Comments

@djordon
Copy link
Collaborator

djordon commented Jan 8, 2025

Bug - Ensure we check for nonempty pre-sign requests

1. Description

The signers do not check whether the pre-sign request contains a non-empty list of deposit or withdrawal requests. Although the coordinator does not construct bitcoin transactions when there aren't any requests to handle, the other signers do not enforce this and they should.

1.1 Context & Purpose

There is no need to allow pre-sign requests to be devoid of user requests, since the signers only act when there is user input. This is because acting costs money in transaction fees, and there is no need to spend any money when you do not need to.

2. Technical Details:

The fix is to check that the request_package field in the pre-sign request is not empty and that each TxRequestIds in that field is non-empty.

2.1 Acceptance Criteria:

  • We do not allow for the creation of a bitcoin transaction that does not service user requests.

3. Related Issues and Pull Requests (optional):

@djordon djordon added bug Something isn't working sbtc signer binary The sBTC Bootstrap Signer. labels Jan 8, 2025
@djordon djordon added this to the sBTC: Key rotation milestone Jan 8, 2025
@djordon djordon self-assigned this Jan 8, 2025
@djordon djordon added this to sBTC Jan 8, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in sBTC Jan 8, 2025
@djordon djordon moved this from Needs Triage to In Review in sBTC Jan 8, 2025
@djordon djordon moved this from In Review to In Progress in sBTC Jan 8, 2025
@djordon djordon moved this from In Progress to In Review in sBTC Jan 8, 2025
@github-project-automation github-project-automation bot moved this from In Review to Done in sBTC Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working sbtc signer binary The sBTC Bootstrap Signer.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant