Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Do not return a signature on Stacks txids mismatch #1132

Closed
1 of 2 tasks
djordon opened this issue Dec 14, 2024 · 1 comment
Closed
1 of 2 tasks

[Feature]: Do not return a signature on Stacks txids mismatch #1132

djordon opened this issue Dec 14, 2024 · 1 comment
Labels
sbtc signer binary The sBTC Bootstrap Signer.

Comments

@djordon
Copy link
Collaborator

djordon commented Dec 14, 2024

Feature - Do not return a signature on Stacks txids mismatch

1. Description

The signers use a debug assert for checking whether the received txid matches the expected txid before providing a signature for a Stacks transaction. They should instead use a proper error.

1.1 Context & Purpose

After a Stacks transaction has passed validation we should have a proper check for whether the sent txid matches the one that the signer generates locally. If they don't match then they should not send a signature and log the issue. The coordinator is not be able to use the signature anyway -- they don't try, they ignore the signature -- but it's better this way since we can see what is happening.

2. Technical Details:

The signers log an error when there is a Stacks txid mismatch and do not provide a signature.

2.1 Acceptance Criteria:

  • The signers log an error when there is a txid mismatch for stacks transactions.
  • The signers do not send a signature when when there is a txid mismatch.

3. Related Issues and Pull Requests (optional):

@djordon djordon added the sbtc signer binary The sBTC Bootstrap Signer. label Dec 14, 2024
@djordon djordon added this to the sBTC: Release polish milestone Dec 14, 2024
@djordon djordon added this to sBTC Dec 14, 2024
@github-project-automation github-project-automation bot moved this to Needs Triage in sBTC Dec 14, 2024
@djordon
Copy link
Collaborator Author

djordon commented Jan 16, 2025

This was fixed in #1165.

@djordon djordon closed this as completed Jan 16, 2025
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in sBTC Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sbtc signer binary The sBTC Bootstrap Signer.
Projects
Status: Done
Development

No branches or pull requests

1 participant