Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pinocchio.XYZQUATToSE3(np.array([ ]) takes in any size of the array #2072

Closed
thanhndv212 opened this issue Oct 31, 2023 · 2 comments · Fixed by #2073
Closed

pinocchio.XYZQUATToSE3(np.array([ ]) takes in any size of the array #2072

thanhndv212 opened this issue Oct 31, 2023 · 2 comments · Fixed by #2073
Assignees

Comments

@thanhndv212
Copy link

Hi.
Apparently, as I understand, the function pinocchio.XYZQUATToSE3(np.array([ ]) should take in only numpy.array which has a shape of (7, ), but strangely it returns regardless of the numpy.array input.

An error should be given when the shape of the array is incorrect. I suppose it could be fixed in pinocchio_pywrap

Python 3.10.12 (main, Jun 11 2023, 05:26:28) [GCC 11.4.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import pinocchio as pin
pin.XYZQUATToSE3(np.array([1])))
print(pin.XYZQUATToSE3(np.array([1, 2, 3])))
print(pin.XYZQUATToSE3(np.array([1, 2, 3, 4, 5])))>>> import numpy as np
>>> 
>>> print(pin.XYZQUATToSE3(np.array([1])))
  R =
         -inf  4.74124e-127  1.05712e+181
 4.74124e-127             1  1.72355e-141
-1.05712e+181  1.72355e-141          -inf
  p =            1            0 1.42202e-319

>>> print(pin.XYZQUATToSE3(np.array([1, 2, 3])))
  R =
 -9 -12   6
 12  -7   4
 -6   4  -1
  p = 1 2 3

>>> print(pin.XYZQUATToSE3(np.array([1, 2, 3, 4, 5])))
  R =
-49 -28  46
 52 -39   4
-14  44 -25
  p = 1 2 3

@jcarpent
Copy link
Contributor

@jorisv When you have time, it would be nice to look at this issue.

@jorisv jorisv self-assigned this Oct 31, 2023
@jorisv jorisv linked a pull request Oct 31, 2023 that will close this issue
@jcarpent
Copy link
Contributor

jcarpent commented Nov 1, 2023

Solved via #2073

@jcarpent jcarpent closed this as completed Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants