Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hmac improvements #251

Open
arj03 opened this issue Aug 18, 2021 · 0 comments
Open

hmac improvements #251

arj03 opened this issue Aug 18, 2021 · 0 comments
Assignees

Comments

@arj03
Copy link
Member

arj03 commented Aug 18, 2021

I was looking at how we handle hmac currently and found a few things:

  • hmacKey is always defined to null, it should be possible to set it from config
  • sometimes the variable is not used

Should be done on top of this branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant