Unreadable components

[dartt0n]

First of all, thank you for porting the theme! However, at the moment, the popup window with the warning appears in a way that is difficult to read, as it is white on a bright yellow background

The Vscode version of this theme does not contain this issue

I have no experience with Zed Themes yet, but maybe this line could be the problem:

srcery-zed/themes/zed-srcery.json

Line 136 in 605d686

"warning.background": null,

I believe it should be xgray1 color (#262626)

[dartt0n]

Going through debug mode for theme, there are some more issues:

Tinted Yellow Button

Any Button while Pressed

Covered Tinted Icons Button

Filled Blue and Yellow Buttons

Dragged window

Original:

This region should have border or different background color

Example from Quill theme

Success & Info Text is the same color as background

[izuzak]

Many thanks for reporting this, @dartt0n! 🙇 Since you already spent some time looking into this and have VSCode set up (for comparisons) -- would you be interested in opening a PR to adjust the colors? Or at least suggesting the right colors for the things that don't look right? 💭 If not, I should be able to find some time this week to take a look.

[dartt0n]

Hi! I have tried to change the theme and prepare the PR, but I didn't have enough time to finish before the national holidays. I'll definitely try again later when I get back to work properly. So far, I have such findings:

Regarding messages, filled & tinted buttons issue:

I have an idea to use the same combination of colors as in Srcery Vim repository for Lightline plugin:

Another idea was to highlight using border color as it is in Quill Theme:

Colors here would be:

IMG	USAGE	NR	VAR	HEX	RGB	HSL
	Accent BG/Border	6	g:srcery_cyan	#0AAEB3	10, 174, 179	182, 89%, 37%
	Warning BG/Border	3	g:srcery_yellow	#FBB829	251, 184, 41	41, 96%, 57%
	Positive BG/Border	2	g:srcery_green	#519F50	81, 159, 80	119, 33%, 47%
	Negative BG/Border	1	g:srcery_red	#EF2F27	239, 47, 39	2, 86%, 55%
	Dark FG	0	g:srcery_black	#1C1B19	28, 27, 25	40, 6%, 10%
	Light FG	15	g:srcery_bright_white	#FCE8C3	252, 232, 195	39, 90%, 88%
	Light BG	236	g:srcery_xgray2, g:srcery_xgray2_cterm	#303030	48, 48, 48	0, 0%, 19%
	Dark BG	7	g:srcery_white	#BAA67F	186, 166, 127	40, 30%, 61%

For dragged window two options:
Either make it semitransparent using:

IMG	USAGE	NR	VAR	HEXA	RGBA	HSLA
	black	0	g:srcery_black	#1C1B19CC	28, 27, 25, 204	40, 6%, 10%, 80%

Or a little bit brighter using:

IMG	USAGE	NR	VAR	HEX	RGB	HSL
	xgray2	236	g:srcery_xgray2, g:srcery_xgray2_cterm	#303030	48, 48, 48	0, 0%, 19%

Thank you for improving this theme. Perhaps these colors are not final, because it is difficult to imagine them in head without good visualization. Unfortunately, I have not yet had the opportunity to understand the details of how Zed uses theme json files for displaying specific elements, and my trivial attempts to adjust colors have not been successful (seems like fields "warning", "success", "info" etc does not affect reported above problems).