Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Frontend] - Events View Page #334

Open
Kartik-Aggarwal5 opened this issue Mar 23, 2023 · 4 comments
Open

[Frontend] - Events View Page #334

Kartik-Aggarwal5 opened this issue Mar 23, 2023 · 4 comments
Assignees
Labels

Comments

@Kartik-Aggarwal5
Copy link
Contributor

Figma Link: https://www.figma.com/file/ILRciTrTtncSzE8ZqC1dzo/Sproul.club?node-id=1-3868&t=z4uEsQQWiA1SNe8L-0
File name is: High-Fi +Figma Prototype

The structure for this project is a bit different (better) than previous projects you might have worked on.
You can find the Events folder in src -> pages -> events

Description: Follow the Figma file to create the events page! :)

Suggestions/Points to Remember:

  • Please create a separate branch off of develop but don't overdo it. (fewer branches make life easy)
@ggams2020
Copy link

@Kartik-Aggarwal5 @nico-galin A few questions:

  1. Do you have a designated URL yet for this page or do you want me to build that out too?
  2. Is there a typescript file already created for this page or would you like me to create one (probably under components --> layout).
  3. Is there any data to include or should I put arbitrary content on the page for now?

@Kartik-Aggarwal5
Copy link
Contributor Author

You should be able to find a folder named events under pages. All the files are under it. You can go with arbitrary data but try to pass them as props so that it is easier for us to integrate.

@ggams2020
Copy link

@nico-galin @Kartik-Aggarwal5 Design question: What should be in the red circle below? There's no design component for a heart that hasn't been clicked, only one that has. See screenshot below
Screen Shot 2023-04-02 at 4 34 37 PM

@ggams2020
Copy link

Also, what's the best way to pass in Props to the Events tsx file for testing purposes? For now, I have the Event object integrated but I just define it locally instead of passing actual Props data in. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants